Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payload error on some searches #41

Open
kltm opened this issue Aug 3, 2013 · 5 comments
Open

Payload error on some searches #41

kltm opened this issue Aug 3, 2013 · 5 comments

Comments

@kltm
Copy link
Member

kltm commented Aug 3, 2013

From David:
I searched on Lrp4 and selected the mouse gene. Amigo2 reported 29
results. When I page to results 11-20, the table is blank even though it
says "showing 11-20"

@kltm
Copy link
Member Author

kltm commented Aug 3, 2013

To reproduce:
Go to Search, type "Lrp4", select MGI Source filter, select "Lrp4" gp link, page through the pinned annotations.

@kltm
Copy link
Member Author

kltm commented Aug 3, 2013

Yet 21-29 seems to work fine. Taking a look, it seems there is an error
in the JSON parsing of the payload coming back from the server. This
likely means that either the loader is loading something wrong or there
is some serious input problem (although a quick scan of the JSON didn't
show any obvious problem in annotation_extension_json).

@kltm
Copy link
Member Author

kltm commented Sep 19, 2013

A little poking has turned up that it chokes on: "transports_or_maintains_localization_of", which should not be there, it should be a JSON object to render correctly. This puts the root bug up in owltools. However, it would be nice to not have the crashes and actually display errors, so I've made it a little more robust down here so that errors get passed through with a "?" tagged onto the end.

I'll deal with the owltools/loader issue separately.

@kltm kltm closed this as completed Sep 19, 2013
@kltm kltm changed the title payload error on some searches Payload error on some searches Apr 1, 2015
@kltm
Copy link
Member Author

kltm commented Apr 1, 2015

Stepping back from showstopper since AmiGO has a workaround for the upstream error. However, now that clients are contacting GOlr directly, it would be good to get the to bottom of this issue.

@kltm kltm reopened this Apr 1, 2015
@kltm
Copy link
Member Author

kltm commented Apr 1, 2015

Example of bad data:

http://golr.berkeleybop.org/select?defType=edismax&qt=standard&wt=json&indent=on&fl=source%2Cbioentity%2Cbioentity_internal_id%2Cbioentity_label%2Cbioentity_name%2Cannotation_class%2Cannotation_class_label%2Cevidence_type%2Caspect%2Ctype%2Ctaxon%2Ctaxon_label%2Cdate%2Cassigned_by%2Cbioentity_isoform%2Cpanther_family%2Cpanther_family_label%2Cannotation_extension_json%2Csynonym%2Cevidence_with%2Creference&facet=false&json.nl=arrarr&q=*%3A*&rows=100&start=0&fq=document_category%3A%22annotation%22&fq=bioentity%3A%22MGI%3AMGI%3A103294%22

there is the line:

"annotation_extension_json":["regulates_o_has_agent"],

which is obviously not a healthy JSON relation. Compare to:

"annotation_extension_json":["{\"relationship\": {\"relation\": [{\"id\": \"BFO:0000066\", \"label\": \"occurs in\"}], \"id\": \"EMAP:5134\", \"label\": \"TS21 dorsal root ganglion\"}}","{\"relationship\": {\"relation\": [{\"id\": \"RO:0002296\", \"label\": \"results in development of\"}], \"id\": \"CL:0000101\", \"label\": \"sensory neuron\"}}"],

from:

http://golr.berkeleybop.org/select?defType=edismax&qt=standard&wt=json&indent=on&fl=source%2Cbioentity%2Cbioentity_internal_id%2Cbioentity_label%2Cbioentity_name%2Cannotation_class%2Cannotation_class_label%2Cevidence_type%2Caspect%2Ctype%2Ctaxon%2Ctaxon_label%2Cdate%2Cassigned_by%2Cbioentity_isoform%2Cpanther_family%2Cpanther_family_label%2Cannotation_extension_json%2Csynonym%2Cevidence_with%2Creference&facet=false&json.nl=arrarr&q=*%3A*&rows=100&start=0&fq=document_category%3A%22annotation%22&fq=bioentity%3A%22MGI%3AMGI%3A97290%22

These examples are from @selewis and @hdietze.

@kltm kltm added this to the 2.3 milestone Apr 1, 2015
@kltm kltm modified the milestones: 2.3, 2.4 Aug 26, 2015
@kltm kltm modified the milestones: 2.4, 2.5 Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant