Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor visualize client/server components amigo so that they all live in VisualizeServer.pm #185

Open
kltm opened this issue Apr 8, 2015 · 3 comments
Open

Refactor visualize client/server components amigo so that they all live in VisualizeServer.pm #185

kltm opened this issue Apr 8, 2015 · 3 comments
Labels
bug (B: affects usability) enhancement
Milestone
2.5

Comments

@kltm
Copy link
Member

kltm commented Apr 8, 2015

There are currently issues dealing with redirects and URL sizes when trying to create graphs using the AmiGO clients for the Visualize service.

The easiest way around these it to refactor all of the visualization clients directly into VisualizeServer.pm and rejigger the linking.
@kltm kltm added this to the 2.3 milestone Apr 8, 2015
@kltm kltm mentioned this issue Apr 8, 2015
Closed
@kltm
Copy link
Member Author

kltm commented Apr 10, 2015

Progress with hidden POST variables; maybe can't mix GET and POST?
Refactor of that section largely finished.

@kltm
Copy link
Member Author

kltm commented Apr 10, 2015

While the bulk of the work is done, it cannot be closed until visualize also has a nice dispatch (some work there started). This will fix two things 1) make the tests nice again and 2) allow for decent get_interlink() variables to be used with the POSTs in visualize_amigo.tmpl and visualize_freeform.tmpl (as the run mode will be covered by the dispatch, removing the need for the hidden variables).

kltm added a commit that referenced this issue Apr 10, 2015
@kltm
updated tests to be compatible with an incomplete #185
a9ccc6e
kltm added a commit that referenced this issue Apr 10, 2015
@kltm
Visualize sub-system refactor to remove any need of redirects in amigo
869ccd8 
proper by placing all clients and links into visualize.

As well, started separating a bit more to get ready for visualize to
have its own dispatch, like amigo.

A fair bit moved around, so testing would be nice.

This is most of the work for #185.
@kltm
Copy link
Member Author

kltm commented Apr 10, 2015

Still TODO:

  • dispatch (like amigo; gets run modes implied)
  • fix get_interlink and make sure visualize_*.tmpl use interlinks from WebApp.pm rather than the hard-code path (not done due to above and cannot mix GET and POST args apparently)
  • tests to check the different run modes
  • (maybe) add forwarding for amigo/visualize to visualize/client/amigo

@kltm kltm modified the milestones: 2.3, 2.4 Aug 26, 2015
@kltm kltm modified the milestones: 2.4, 2.5 Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug (B: affects usability) enhancement
Projects
None yet
Milestone
2.5
Development

No branches or pull requests
1 participant
@kltm