Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This plugin is not properly prepared for localization #56

Open
ntwb opened this issue Apr 9, 2017 · 1 comment
Open

This plugin is not properly prepared for localization #56

ntwb opened this issue Apr 9, 2017 · 1 comment
Milestone

Comments

@ntwb
Copy link

ntwb commented Apr 9, 2017

Via https://translate.wordpress.org/locale/en-au/default/wp-plugins/slack

Currently only the readme is available for translation

See also:

https://wordpress.slack.com/archives/C0E7F4RND/p1491762804232387

[4:33]  
Import of slack
_Time: Sun, 09 Apr 2017 18:33:18 +0000, Development Log_
Code for stable (slack/tags/0.6.0/) in process...
This plugin doesn't use `load_plugin_textdomain()`.
Code for stable was processed.
Readme for stable (slack/tags/0.6.0/) in process...
The GlotPress projects were updated.
Result of the POT import: 5 new strings added, 0 updated, 0 fuzzied, and 0 obsoleted.
Readme for stable  was processed.

https://wordpress.slack.com/archives/C0E7F4RND/p1491762810232749

[4:33]  
Import of slack
_Time: Sun, 09 Apr 2017 18:33:25 +0000, Development Log_
Code for dev (slack/trunk/) in process...
This plugin doesn't use `load_plugin_textdomain()`.
Code for dev was processed.
Readme for dev (slack/trunk/) in process...
The GlotPress projects were updated.
Result of the POT import: 4 new strings added, 0 updated, 0 fuzzied, and 0 obsoleted.
Readme for dev  was processed.

https://wordpress.slack.com/archives/C0E7F4RND/p1491763103250897

4:38 AM] 
Translation Sync for slack
_Time: Sun, 09 Apr 2017 18:38:23 +0000_
Translation sync from dev-readme to stable-readme in process...
    No translations are available to sync.
Translation sync was successfully processed.

https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#loading-text-domain

"After WordPress 4.6 came out, translations now take translate.wordpress.org as priority and so plugins that are translated via translate.wordpress.org do not necessary require load_plugin_textdomain() anymore.
If you don’t want to add a load_plugin_textdomain() call to your plugin you have to set the Requires at least: field in your readme.txt to 4.6."

To resolve, either add the call to load_plugin_textdomain() or bump required to 4.6

@gedex gedex added this to the 0.6.1 milestone Apr 10, 2017
@gedex
Copy link
Owner

gedex commented Apr 10, 2017

Thanks for reporting this @ntwb. Will be fixed in 0.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants