Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net radiation not gap-filled in LSM data #87

Open
SamanthaBiegel opened this issue Apr 10, 2024 · 5 comments
Open

Net radiation not gap-filled in LSM data #87

SamanthaBiegel opened this issue Apr 10, 2024 · 5 comments

Comments

@SamanthaBiegel
Copy link
Contributor

Net radiation (NETRAD variable) is only gap-filled in the rsofun drivers workflow (

fill_netrad <- function(df){
). Is there any reason why this gap-filling step is not applied to all data products?
@stineb

@stineb
Copy link
Contributor

stineb commented Apr 10, 2024

I didn't expect (and find) gaps in the meteorological drivers. Do you?

@SamanthaBiegel
Copy link
Contributor Author

Yes, I found 17% missing NETRAD values in the fluxnet-formatted data

@olivierbonte
Copy link

Hi,

First and foremost thank you @stineb and collaborators for creating this dataset, accessing an extended version of the PLUMBER2 dataset has been great so far!

For FluxDataKitv3.3, I can confirm for the sites BE-Bra, DE-Thai and DE-Tha, there is data missing for net radiation in the netcdf format. I suppose this stems from the fact that in Ukkola et al. (2022), net radiation is not considered as a meteorological variable ("Met" in Table 1 from this paper), but rather a flux, for which gapfilling is less stringent as far as I understand (as it is not used as driver for land surface models).

For the application I am currently working on, net radiation is a forcing however, as it drivers evaporation in Priestley-Taylor/Penman-Monteith type models.

As mentioned by @SamanthaBiegel, the netrad filling is applied for formatting to rsofun drivers, see:

data = purrr::map(data, ~fill_netrad(.))

As far as I can see, this is not done for fluxnet formatting (basing myself on https://github.com/geco-bern/FluxDataKit/blob/24237bd46aaa4d65d9395391adf7360d53b6562b/R/fdk_process_lsm.R)
Could this also be added to the next version of FluxDataKit? Although I am not that familiar with this codebase, I would be happy to help in the implementation if need be.

Thanks in advance!
Olivier

@stineb
Copy link
Contributor

stineb commented Dec 13, 2024

Dear @olivierbonte , thanks for the suggestion. Before it is implemented (if we decide to do so), feel free to use the function fill_netrad() for your application. It does an imputation using K nearest neighbours. The function itself is not public (exported as part of the package), but you can source it from the source file yourself. I hope this is helpful for you.

@olivierbonte
Copy link

Thank you for the suggestion, I'll definitely consider using the function directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants