diff --git a/stroom-core-client/src/main/java/stroom/processor/client/presenter/ProcessorPresenter.java b/stroom-core-client/src/main/java/stroom/processor/client/presenter/ProcessorPresenter.java index 828c56dc7e2..bfbae8e4291 100644 --- a/stroom-core-client/src/main/java/stroom/processor/client/presenter/ProcessorPresenter.java +++ b/stroom-core-client/src/main/java/stroom/processor/client/presenter/ProcessorPresenter.java @@ -71,9 +71,9 @@ public class ProcessorPresenter extends MyPresenterWidget { @@ -146,7 +146,7 @@ private void createButtons() { } })); - if (allowEdit) { + if (allowCreate) { duplicateButton = processorListPresenter.getView().addButton(SvgPresets.COPY); duplicateButton.setTitle("Duplicate Processor"); registerHandler(duplicateButton.addClickHandler(event -> { @@ -252,7 +252,7 @@ public MultiSelectionModel getSelectionModel() { } private void addProcessor() { - if (allowEdit) { + if (allowCreate) { edit(null, defaultExpression, null); } } @@ -261,7 +261,7 @@ private void addProcessor() { * Make a copy of the currently selected processor */ private void duplicateProcessor() { - if (allowEdit) { + if (allowCreate) { // Now create the processor filter using the find stream criteria. final ProcessorFilterRow row = (ProcessorFilterRow) selectedProcessor; final ProcessorFilter processorFilter = row.getProcessorFilter(); @@ -280,7 +280,7 @@ private void duplicateProcessor() { } private void editProcessor() { - if (allowEdit && selectedProcessor != null) { + if (selectedProcessor != null) { if (selectedProcessor instanceof ProcessorFilterRow) { final ProcessorFilterRow processorFilterRow = (ProcessorFilterRow) selectedProcessor; final ProcessorFilter filter = processorFilterRow.getProcessorFilter(); diff --git a/unreleased_changes/20240326_152934_719__4183.md b/unreleased_changes/20240326_152934_719__4183.md new file mode 100644 index 00000000000..337c0747267 --- /dev/null +++ b/unreleased_changes/20240326_152934_719__4183.md @@ -0,0 +1,24 @@ +* Issue **#4183** : Fix processor filter edit. + + +```sh +# ******************************************************************************** +# Issue title: Can't edit a Proc Filter from the System/Processors tab +# Issue link: https://github.com/gchq/stroom/issues/4183 +# ******************************************************************************** + +# ONLY the top line will be included as a change entry in the CHANGELOG. +# The entry should be in GitHub flavour markdown and should be written on a SINGLE +# line with no hard breaks. You can have multiple change files for a single GitHub issue. +# The entry should be written in the imperative mood, i.e. 'Fix nasty bug' rather than +# 'Fixed nasty bug'. +# +# Examples of acceptable entries are: +# +# +# * Issue **123** : Fix bug with an associated GitHub issue in this repository +# +# * Issue **namespace/other-repo#456** : Fix bug with an associated GitHub issue in another repository +# +# * Fix bug with no associated GitHub issue. +```