Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document friction parameters for each physics engine #258

Open
chapulina opened this issue May 14, 2021 · 2 comments
Open

Document friction parameters for each physics engine #258

chapulina opened this issue May 14, 2021 · 2 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@chapulina
Copy link
Contributor

We currently support some physics parameters from the SDF spec, as well as some extra ones with custom tags, and it's difficult for users to know what they are and which ones are supported by each physics engine.

To make things more complicated, because of #49, users may observe different behaviours with the same engine and ign-physics version, but different Ubuntu versions. See how this block of code is dependent on the DART version:

https://github.com/ignitionrobotics/ign-physics/blob/1a98780ca5f6287a650f954ff2e14701bd131fe3/dartsim/src/SDFFeatures.cc#L812-L818

I think friction deserves its own tutorial in the tutorials folder.

Parameters to document:


This external project comparing friction between Gazebo classic and Ignition Gazebo is relevant: https://github.com/athackst/ignition_vs_gazebo/tree/main/friction

@chapulina chapulina added documentation Improvements or additions to documentation enhancement New feature or request labels May 14, 2021
@chapulina chapulina added the good first issue Good for newcomers label May 14, 2021
@addy1997
Copy link

addy1997 commented Aug 14, 2021

@chapulina, I want to help with this. If I understand it correctly, is there a tutorial to be written on friction highlighting the above params?

@chapulina
Copy link
Contributor Author

Thanks, @addy1997 ! Yes, you can add a tutorial to this repository's tutorials folder. You'll need to dig in a bit to test each parameter inside <friction> with each of the supported physics engines: DART, Bullet and TPE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants