Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project 4 Feedback #1

Open
codepathreview opened this issue Apr 3, 2017 · 0 comments
Open

Project 4 Feedback #1

codepathreview opened this issue Apr 3, 2017 · 0 comments

Comments

@codepathreview
Copy link

Week 4: Twitter Redux

👍 nice work. A few notes after checking out the code:

  • Good to see you used ViewPager and TabLayout. These
    components are recommended by Material Design to enhance user experience and are found in majority of the apps. ViewPager can also be used separately without TabLayout to show paging of content using swipe in any section of the screen layout.
  • Nice to see you used a drawable and styles to customize the app. Get more familiar with creating custom drawables and styles by trying to customize different widgets.
  • Nice to see you played around with styling the sliding tab strip
  • Remember to add an indeterminate progress indicator during background tasks
  • Consider not calling the ProfileActivity directly from the profile pic on click listener which is part of the Fragment as the Fragment should be de-coupled from any specific Activity to allow it to be modular. See this communicating with fragments for more details.
  • Consider performing DB operations, such as save, select, etc., asynchronously, on a background thread, to potentially prevent blocking the main thread.
  • Glad to see you properly hooked up each of the different timelines to infinitely paginate.
  • Nicely done architecting the fragments (base class and extension classes) such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ!
  • Consider using a more robust HTTP client lib such as Retrofit or OkHttp.

Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.

Following the bootcamp, we are going to have a public demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant