From f5f9c30675e4df0171dd3aa63a800ef12fd19ec8 Mon Sep 17 00:00:00 2001 From: Jim Garlick Date: Thu, 6 Apr 2023 14:20:10 -0700 Subject: [PATCH 1/2] build: require flux-core >= 0.49.0 Problem: the pmix shell plugin requires changes that were added to flux-core 0.49.0 but the minimum version required by configure is 0.46.0. flux-pmix is disabled unless specifically enabled by the -opmi=LIST shell option, but earlier versions of flux-core restrict the values that this shell option can have so that pmix can never be enabled. require flux-core >= 0.49.0 --- config/ax_flux_core.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/ax_flux_core.m4 b/config/ax_flux_core.m4 index 4141389..e2d551f 100644 --- a/config/ax_flux_core.m4 +++ b/config/ax_flux_core.m4 @@ -51,7 +51,7 @@ AC_DEFUN([AX_FLUX_CORE], [ PKG_CONFIG_PATH=${prefix}/lib/pkgconfig:${PKG_CONFIG_PATH} export PKG_CONFIG_PATH - PKG_CHECK_MODULES([FLUX_CORE], [flux-core >= 0.46.0], + PKG_CHECK_MODULES([FLUX_CORE], [flux-core >= 0.49.0], [ FLUX_PREFIX=`pkg-config --variable=prefix flux-core` LIBFLUX_VERSION=`pkg-config --modversion flux-core` From da3a1cfe7764218d51aa88b9929846b97bc28be0 Mon Sep 17 00:00:00 2001 From: Jim Garlick Date: Thu, 6 Apr 2023 15:39:33 -0700 Subject: [PATCH 2/2] README.md: drop installation section Problem: installation section describes incorrect procedure for side-install. Just drop the instructions as packagers probably already know what they are doing. --- README.md | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/README.md b/README.md index a7f177b..3b2ed26 100644 --- a/README.md +++ b/README.md @@ -21,19 +21,6 @@ or by setting the `FLUX_PMI_CLIENT_METHODS` environment variable globally: FLUX_PMI_CLIENT_METHODS="simple pmix single" ``` -### installation - -Typically this project would be configured with the same `--prefix` as -flux-core. If that is not practical, for example in a spack environment, -then flux-shell and flux-broker can be told to look elsewhere for plugins by -setting, respectively: - -```sh -FLUX_SHELL_RC_PATH=${prefix}/etc/flux/shell/lua.d:$FLUX_SHELL_RC_PATH -FLUX_PMI_CLIENT_SEARCHPATH=${prefix}/lib/flux/upmi/plugins:$FLUX_PMI_CLIENT_SEARCHPATH -``` -where `${prefix}` is the installation prefix of this project. - ### limitations The pmix specs cover a broad range of topics. Although the shell plugin is