Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: finalize the 5.0.0 release. #528

Closed
CosminPerRam opened this issue Jan 31, 2024 · 6 comments
Closed

feat: finalize the 5.0.0 release. #528

CosminPerRam opened this issue Jan 31, 2024 · 6 comments

Comments

@CosminPerRam
Copy link
Member

More than a week ago we finally released 5.0.0-beta.0!

And now, to get it out of beta we would need to:

It would be nice to add a 'version' stabilized field (#468) but could come later on as a backwards compatible update.

Feel free to mention any thoughts regarding finalizing this major version.

@podrivo
Copy link
Contributor

podrivo commented Feb 2, 2024

CI GIDs testing depends on the Rust repo. Here's the issue about this: gamedig/rust-gamedig#184

I'm all in favor of adding game aliases for a better usability of the library, as well as having compatibility of GIDs, even if we decide to change game IDs naming. There's more examples on the PR (#487). Happy to update it for the latest version!

I can start working on the 'version' stabilized field, as this might be an easy one to tackle.

Another one that might be interesting for us to start talking, but not necessarily be part of v5, is the use of RCON.
I'm not sure if RCON should be part of GameDig, but it's a good debate to have with the community, because it's been asked since 2016 (#46).

So the question is: should we support RCON or not?

I know you can query more info using RCON, but the main feature is to remote control the server, meaning you can execute a variety of commands to manage your server. I personally think this is out of scope of GameDig, but it would be good to know how others think about it.

@CosminPerRam
Copy link
Member Author

CosminPerRam commented Feb 3, 2024

should we support RCON or not

Yes.

I know you can query more info using RCON, but the main feature is to remote control the server, meaning you can execute a variety of commands to manage your server. I personally think this is out of scope of GameDig, but it would be good to know how others think about it.

We would use RCON in the same scope as we have done so far: just to query servers, nothing more (like remote control).

This could come eventually later on.

@podrivo
Copy link
Contributor

podrivo commented Feb 4, 2024

About naming, if we move forward with the alias for games, should we kill old_id in favor of alias?

Another one to maybe consider, is using the Steam API to query servers (#484).

@CosminPerRam
Copy link
Member Author

Another one to maybe consider, is using the Steam API to query servers

A possible nice feature to add later on.

About naming, if we move forward with the alias for games, should we kill old_id in favor of alias?

No, renaming old_id to alias could confuse stuff and that word wouldn't really represent of what it is.

@podrivo
Copy link
Contributor

podrivo commented Feb 6, 2024

I'm asking this, because it might have conflicting issues when having both options in a game.
For example:

hiddendangerous2: {
  name: 'Hidden & Dangerous 2',
  release_year: 2003,
  options: {
    port: 11001,
    port_query_offset: 3,
    protocol: 'gamespy1'
  },
  extra: {
    old_id: 'had2',
    alias: 'had2'
  }
}

Edit: Or maybe just don't do this.

@podrivo
Copy link
Contributor

podrivo commented Feb 10, 2024

Here are the PRs about top level version and games.extra.alias:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants