Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text input width calculation #144

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

Katajisto
Copy link
Collaborator

@Katajisto Katajisto commented Oct 15, 2024

The text input calculation was incorrectly subtracting 3 from the default values length, even though it should only be done for the whole line width on the windowSizeMsg in order to not overflow the line with '> ' + textInput. It was also overwriting the default 30 character width with the default value width, which in the case of for example 'main' default value would result in a 4 character wide input.

@Katajisto Katajisto requested a review from majori October 15, 2024 08:19
@Katajisto Katajisto merged commit e7e2b9d into main Oct 15, 2024
6 checks passed
@Katajisto Katajisto deleted the fix/fix-text-input-width-calculations branch October 15, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants