From 277b22a97f4745c93b7aad7d5714a37f57dd4701 Mon Sep 17 00:00:00 2001
From: Kevin Grandon <kevingrandon@yahoo.com>
Date: Thu, 25 Oct 2018 12:41:27 -0700
Subject: [PATCH] Implement CI for multiple node versions (#148)

Implements Docker services for running against multiple node versions at once using a build arg.
Curently runs against node 8 and node 10.
---
 .buildkite/pipeline.yml | 35 +++++++++++++++++++++++++++++++++++
 Dockerfile              |  3 ++-
 docker-compose.yml      |  6 ++++++
 3 files changed, 43 insertions(+), 1 deletion(-)

diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml
index d8dea3c..470b8a6 100644
--- a/.buildkite/pipeline.yml
+++ b/.buildkite/pipeline.yml
@@ -6,6 +6,13 @@ steps:
         image-repository: 027047743804.dkr.ecr.us-east-2.amazonaws.com/uber
     agents:
       queue: builders
+  - name: ':docker: :package: node8'
+    plugins:
+      'docker-compose#v1.7.0':
+        build: fusion-plugin-rpc-redux-react-node-last
+        image-repository: 027047743804.dkr.ecr.us-east-2.amazonaws.com/uber
+    agents:
+      queue: builders
   - wait
   - command: yarn flow
     name: ':flowtype:'
@@ -14,6 +21,13 @@ steps:
         run: fusion-plugin-rpc-redux-react
     agents:
       queue: workers
+  - command: yarn flow
+    name: ':flowtype: node8'
+    plugins:
+      'docker-compose#v1.7.0':
+        run: fusion-plugin-rpc-redux-react-node-last
+    agents:
+      queue: workers
   - name: ':eslint:'
     command: yarn lint
     plugins:
@@ -21,6 +35,13 @@ steps:
         run: fusion-plugin-rpc-redux-react
     agents:
       queue: workers
+  - name: ':eslint: node8'
+    command: yarn lint
+    plugins:
+      'docker-compose#v1.7.0':
+        run: fusion-plugin-rpc-redux-react-node-last
+    agents:
+      queue: workers
   - name: ':chrome: :white_check_mark:'
     command: .buildkite/browserTests
     plugins:
@@ -28,6 +49,13 @@ steps:
         run: fusion-plugin-rpc-redux-react
     agents:
       queue: workers
+  - name: ':chrome: :white_check_mark: node8'
+    command: .buildkite/browserTests
+    plugins:
+      'docker-compose#v1.7.0':
+        run: fusion-plugin-rpc-redux-react-node-last
+    agents:
+      queue: workers
   - name: ':node: :white_check_mark:'
     command: .buildkite/nodeTests
     plugins:
@@ -35,3 +63,10 @@ steps:
         run: fusion-plugin-rpc-redux-react
     agents:
       queue: workers
+  - name: ':node: :white_check_mark: node8'
+    command: .buildkite/nodeTests
+    plugins:
+      'docker-compose#v1.7.0':
+        run: fusion-plugin-rpc-redux-react-node-last
+    agents:
+      queue: workers
diff --git a/Dockerfile b/Dockerfile
index 0e3deb8..edad0cc 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,4 +1,5 @@
-FROM uber/web-base-image:1.0.9@sha256:98ad970fd8dadc43ecec9909e27dc543a88d096f722d00e07e0b25047e9388bc
+ARG BASE_IMAGE=uber/web-base-image:2.0.0
+FROM $BASE_IMAGE
 
 WORKDIR /fusion-plugin-rpc-redux-react
 
diff --git a/docker-compose.yml b/docker-compose.yml
index c8b4f23..2d470aa 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -17,3 +17,9 @@ services:
       - BUILDKITE_BUILD_URL
       - BUILDKITE_PROJECT_SLUG
       - BUILDKITE_COMMIT
+  fusion-plugin-rpc-redux-react-node-last:
+    extends: fusion-plugin-rpc-redux-react
+    build:
+      context: .
+      args:
+        BASE_IMAGE: 'uber/web-base-image:1.0.9'