Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular version #27

Open
kylecordes opened this issue May 20, 2017 · 5 comments
Open

Angular version #27

kylecordes opened this issue May 20, 2017 · 5 comments

Comments

@kylecordes
Copy link

This example is on Angular 2.3.1, from Dec. 2016, six months ago. I recommend updating it to current Angular (4.1.3 as I write this, https://github.com/angular/angular/blob/master/CHANGELOG.md ), to verify and demonstrate whether fuse-box can work with current-ish versions.

@nchanged
Copy link
Contributor

Hi! It works, it's just angular materials changed the API completely, and we don't be have time and resources to update it. but we could get rid of the todo app and provide something simpler like hello world

@devmondo
Copy link
Member

@kylecordes could you contribute to this if you know how to fix it?

@kylecordes
Copy link
Author

@devmondo The material API / packaging is a little different than before, as they work their way through their beta process. I've followed along the Material development with other tooling, and never needed more than a few minutes to update a project.

Here is a PR, partial update/fix to use Angular 4:

#28

Making this run is awaiting module resolution fix for fuse-box:

fuse-box/fuse-box#324

There is also a broader challenge:

The Angular team and community have shifted much attention to Angular AOT ("Ahead of Time") template compilation and tree shaking. There are many moving pieces to get in place, to create alternative Angular build tooling competitive with the official Angular CLI (and importantly, its non-trivial webpack plugin). This will probably have to wait for someone with a strong motivation to recreate this stuff for fuse-box.

@nchanged
Copy link
Contributor

Thanks @kylecordes !
I will hold off merging your PR then. Need to take a look at this packaging issue. Tree shaking is coming to fuse-box very soon, that's what we are busy with.

@devmondo
Copy link
Member

@kylecordes , thanks for the detailed input, we will be working on this one hard to solve it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants