Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature - Marking Dice #15

Open
hkjlee109 opened this issue Jun 29, 2016 · 10 comments
Open

New Feature - Marking Dice #15

hkjlee109 opened this issue Jun 29, 2016 · 10 comments

Comments

@hkjlee109
Copy link
Member

We can mark anything on each side of the dice.

For example,

  • If the request is /dice 2d{@junoya77, @masunghoon, @taewanme, @younggi},
  • then the response would be @taewanme, @junoya77
@jwChung
Copy link
Member

jwChung commented Jun 29, 2016

좋은 생각이네요.

그런데 괄호 안에 슬랙 아이디일 필요가 있나요? {이경준, 정진욱} 이런 사용도 가능한가요?

@hkjlee109
Copy link
Member Author

Good call! Why don't we make it to take any types of input? I think even this would work, {1, 2, 3, jungsu, 4, 6, 6}.

@jwChung
Copy link
Member

jwChung commented Jun 30, 2016

@kwoolytech 걍 String 타입이라도 충분할까요?

@funprog/core 이 이슈 채택해도 되겠습니까?

@younggi
Copy link
Contributor

younggi commented Jun 30, 2016

아이디나 이름으로 뽑기하는 기능 추가 찬성합니다.

@naxxster
Copy link

어떤 단위로 구분할 지에 대해서만 명확해진다면 유용할 것 같네요.

@jwChung
Copy link
Member

jwChung commented Jun 30, 2016

@younggi, @naxxster 님들이 찬성 의견 주셔서, 이슈 채택의 의미로 enhancement 라벨 부여하였습니다.

@hkjlee109
Copy link
Member Author

@jwChung Yup, String sounds good to me. ty all!

@myeesan
Copy link
Contributor

myeesan commented Jul 6, 2016

중복을 허용하나요? 예를 들어 2d{1, 2, 3, 4} 인 경우, 1, 1 결과 값이 나올 수 있나요?

@jwChung
Copy link
Member

jwChung commented Jul 6, 2016

@myeesan 먼저 #6 을 구현한 후 고민하는 것이 어떨까요? #6 이 기존의 중복을 허용하는 #5 기능을 덮어 쓸지 아니면 #5 은 그대로 두고 추가적으로 구현해야할지 결정할필요가 있겠습니다. 이 결정이 먼저 내려진 후에 고려되는 것이 좋을 것 같습니다.

@myeesan
Copy link
Contributor

myeesan commented Jul 6, 2016

@jwChung 넵!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants