Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally disable Embedded Tomcat from starting #12

Closed
rajdavies opened this issue Jun 5, 2016 · 5 comments
Closed

Optionally disable Embedded Tomcat from starting #12

rajdavies opened this issue Jun 5, 2016 · 5 comments

Comments

@rajdavies
Copy link
Contributor

For some cases, where you are creating a non REST based funktion, it would be nice not to have embedded Tomcat start. Pondering best way to disable - property maybe ?

@jstrachan
Copy link
Contributor

jstrachan commented Jun 6, 2016

Agreed.

I think excluding the <artifactId>spring-boot-starter-web</artifactId> should be enough in the pom.xml. FWIW to fix funktionio/funktion#10 I recently switched from tomcat -> jetty so we could use the same servlet engine for camel http and the spring-boot-starter-web.

The only downside of disabling web is we lose actuator metrics and health REST access. Longer term maybe the jolokia agent could detect those and expose them over HTTP? Until then its probably easier to keep the spring-boot-starter-web dependency; even if its just used for metrics & health checks.

@davsclaus
Copy link
Contributor

Yeah IMHO its good to standardize on /health over HTTP for health checks. I suspect its a tad to complicated to disable HTTP and then use something else as health check?

@jstrachan
Copy link
Contributor

yeah - we currently tend to use jetty; though could use undertow instead to reduce the foot print a bit? We need a servlet engine for health checks though - plus for doing mvn fabric8:watch-spring-boot so its very handy!

@davsclaus
Copy link
Contributor

Yeah I have switched funktion to use undertow

@davsclaus
Copy link
Contributor

undertow should be fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants