-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Singularity image does not build #6
Comments
The singularity image used for paper experiments was built a while ago and the tensorflow version is now deprecated. I can share the built image if you want to use the current network implementations (it is just too large to upload to github). Alternatively, you could refactor to use pytorch and funlib.learn.torch which makes things a bit cleaner. |
Bumping the version to 1.15 allows it to build, and if TF respects semver, nothing should have broken. Some of the tests don't pass, although that seems to be for unrelated reasons. |
I do recall that some things in TF changed between those versions (i.e small function name changes, deprecations etc), so you would just have to update the network scripts accordingly |
As for some of the tests failing, these are old and should be updated or removed. We haven't done anything with sqlite, luigi, hdf, or lsd based agglomeration in a while. |
Great, thanks. Also thanks for uploading the tutorials, they'll be a big help. What's the address to reach you now, or is it best to talk to Jan about getting the images and trying to make use of this? |
Ah, I do have it but can't easily log in - try my LMB address cbarnes AT mrc-lmb.cam.ac.uk |
Could malis be removed from these images? It has very restrictive build constraints and is not used by lsd directly; it's also not actually used in any of the downstream cases I've looked at yet where it's imported. |
Yeah my Janelia email ended, just sent you an email. Yep malis could be removed, I believe it was only needed for training the malis loss networks (which we compared against in the study). I will create a new singularity container for training with pytorch soon, the only unfortunate thing is that the pretrained paper networks all used the image from the current build, in which everything is very deprecated. |
To reproduce:
cd singularity make
The text was updated successfully, but these errors were encountered: