-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 9 Support #378
Comments
With Angular 9.1 I am getting the following error: 37 static ?fac: ?ngcc0.??FactoryDef; 9 static ?fac: ?ngcc0.??FactoryDef; |
try to reinstall froala package again
|
I also ran into the same issue as @sheshnathverma. Both the FroalaEditorModule and FroalaViewModule need the generics added. In addition the FroalaEditorDirective imports Renderer which obviously no longer exists in @angular/core v9.x. I have tried to publish a fork with these three fixes, but IVY still doesn't appear to compile correctly with ngcc as I get the following error after making the above changes:
What is the roadmap for Angular 9 / Ivy support for angular-froala-wysiwyg? You can see my changes which may fix the issue here: https://github.com/blingerson/angular-froala-wysiwyg/commits/master |
Same Issue here |
FYI, version 2.9.8 works fine with Angular 9.1 |
@steve-tapley it does not work when IVY is enabled, it only works with angular 9 when IVY is disabled (which is non-default). The three issues mentioned above prevent it from running with IVY enabled. |
@blingerson We are using V2.9.8 in angular 9.1 with Ivy enabled. |
@steve-tapley, v2.9.8 does not compile in our app. The bugs are still in the master branch:
Perhaps you haven't check with the latest angular code? I can assure you that, in my situation, along with others here it definitely does not support angular 9. I got our app working by copying the directives and modules into our codebase and fixing the above issues. We are using angular 9.1.7. |
@steve-tapley you may also want to check with:
Many custom webpack configurations seem like ivy is enabled, but this "ivyEnabled" flag ends up being false. It should be true in both development and production mode. You may want to give it a sanity check to make sure it is truly enabled in your testcase. |
@steve-tapley I have created a pull request with the pertinent changes: It is very possible that since we and others here are using custom webpack configurations that these issues could be due to different tsconfig or webpack loaders. Please consider this pull request to alleviate those issues in the cases where people are having issues. Thanks. |
Any updates about this ? |
It would be great to get the fixes in so we can remove our hacks and get this working with Angular 9. Is there anything I can do to help facilitate getting my pull request merged in? |
any update on this? |
Sorry for not circling back on this sooner, but I just removed my hack and installed v3.2.3 which has my pull request I believe. All is working fine and this issue seems like it can be closed. Thanks! |
any update on this, i getting this error in angular 11 |
When building a library with Angular 9, I get the following error
looks like the editor ModuleWithProviders does not contain a type definition.
The text was updated successfully, but these errors were encountered: