Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resource.$schema and no longer require tabular-data-resource #108

Open
16 tasks
peterdesmet opened this issue Feb 18, 2022 · 0 comments
Open
16 tasks
Labels
complexity:high Likely complex to implement datapackage:v2 function:read_resource Function read_resource() function:write_package Function write_package()
Milestone

Comments

@peterdesmet
Copy link
Member

peterdesmet commented Feb 18, 2022

Changelog: resource.$schema (new)

  • Check $schema
    • If not provided, look for profile (see also Support resource.type #221)
    • If no profile, assume v1
    • If v1: investigate what effect is
    • If v2: interpret new properties
    • If v2+: warn that it may not understand all properties
  • Update implementation
  • Update documentation and mentions of profiles
  • Update tests
  • Update examples

In addition:

Currently, data resources without the profile tabular-data-resource fail:

Error: Resource `validation_report` must have property `profile` with value `tabular-data-resource`.

I notice that resources without such a profile are quite common in the wild. These generic data-resource can use Table Schema in schema, but are not required to do so. Maybe read_resource() should be a bit more lenient and assess in a different way if a resource can be read. I think it already thus by e.g. requiring schema to contain fields.

@peterdesmet peterdesmet added enhancement New feature or request function:read_resource Function read_resource() labels Feb 18, 2022
@peterdesmet peterdesmet added this to the 1.2.0 milestone Mar 27, 2024
@peterdesmet peterdesmet changed the title Should profile=tabular-data-resource be conditional? Support resource.$schema Jul 3, 2024
@peterdesmet peterdesmet added the function:write_package Function write_package() label Jul 3, 2024
@peterdesmet peterdesmet changed the title Support resource.$schema Support resource.$schema and no longer required tabular-data-resource Jul 3, 2024
@peterdesmet peterdesmet changed the title Support resource.$schema and no longer required tabular-data-resource Support resource.$schema and no longer require tabular-data-resource Jul 3, 2024
@peterdesmet peterdesmet added datapackage:v2 complexity:high Likely complex to implement and removed enhancement New feature or request labels Jul 3, 2024
@peterdesmet peterdesmet modified the milestones: 1.2.0, 1.3.0 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:high Likely complex to implement datapackage:v2 function:read_resource Function read_resource() function:write_package Function write_package()
Projects
None yet
Development

No branches or pull requests

1 participant