From ffb087cb29f5029c41e9164780e866e91934ad10 Mon Sep 17 00:00:00 2001 From: roll Date: Sun, 17 Dec 2023 12:18:30 +0000 Subject: [PATCH] Improved tests --- dplib/__spec__/test_model.py | 3 ++- dplib/plugins/dcat/models/package.py | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dplib/__spec__/test_model.py b/dplib/__spec__/test_model.py index 69eb3c6..fb384a1 100644 --- a/dplib/__spec__/test_model.py +++ b/dplib/__spec__/test_model.py @@ -1,3 +1,4 @@ +import json from pathlib import Path import pytest @@ -24,7 +25,7 @@ def test_model_to_path(tmp_path: Path): resource = Resource.from_path("data/resource.json") resource.to_path(path) with open(path) as file: - assert file.read() == '{"name": "name", "path": "table.csv"}' + assert json.loads(file.read()) == {"name": "name", "path": "table.csv"} def test_model_from_path_emtpy_file(): diff --git a/dplib/plugins/dcat/models/package.py b/dplib/plugins/dcat/models/package.py index 86d252d..dd6a77d 100644 --- a/dplib/plugins/dcat/models/package.py +++ b/dplib/plugins/dcat/models/package.py @@ -3,7 +3,6 @@ from typing import Any, List, Optional from rdflib import BNode, Graph, URIRef -from typing_extensions import Self from dplib.error import Error from dplib.model import Model @@ -324,7 +323,7 @@ def to_dp(self) -> Package: return package @classmethod - def from_dp(cls, package: Package) -> Self: + def from_dp(cls, package: Package) -> DcatPackage: """Create a DCAT Package from Data Package Parameters: