Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile is a url rather than string #689

Closed
rufuspollock opened this issue Jun 12, 2020 · 4 comments · Fixed by frictionlessdata/datapackage-v2-draft#42
Closed

Profile is a url rather than string #689

rufuspollock opened this issue Jun 12, 2020 · 4 comments · Fixed by frictionlessdata/datapackage-v2-draft#42
Assignees
Labels
Milestone

Comments

@rufuspollock
Copy link
Contributor

rufuspollock commented Jun 12, 2020

Switch from:

  "profile": "tabular-data-package"
  "profile": "https://specs.frictionlessdata.io/schemas/tabular-data-package.json"

Why?

Reduce magic! See frictionlessdata/frictionlessdata.io#875

@rufuspollock
Copy link
Contributor Author

@roll @akariv @pwalsh does this sound good to you?

@akariv
Copy link
Member

akariv commented Jun 30, 2020

Yes, I agree it's better this way.

@roll
Copy link
Member

roll commented Jul 1, 2020

Sure regarding validation but I have another question - will it still be an indicator of a resource type? (tabular or not). If yes, how to handle it (checking equality to exact URL e.g.)?

@pwalsh
Copy link
Member

pwalsh commented Jul 1, 2020

yes, better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants