Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG Export: if Visibility range is ON, transforms are not working #300

Open
pgilfernandez opened this issue Nov 4, 2024 · 7 comments
Open
Milestone

Comments

@pgilfernandez
Copy link

As you see I'm tinkering a lot with Friction... I hope all this testing, asking things and issue reporting don't annoy you in excess.

I don't know if "Visibility range" is supposed to work for animated SVGs but it looks like to work fine but... if you use it in conjunction with, for instance any transform animation, the only animation you get is the "visibility range" and the transform is gone.

Project file: svga_visibility_range2.zip

I haven't tested other parameter animations, but they might doesn't work neither...

@rodlie
Copy link
Member

rodlie commented Nov 5, 2024

There might be issues, I only use visibility range for video or sound.

@pgilfernandez
Copy link
Author

Well, I found one, it is just to let you know. BTW they are not big deal as you can always play with opacity to bypass the visibility range feature 😉

@rodlie rodlie added this to the 1.0.0 milestone Dec 2, 2024
@rodlie
Copy link
Member

rodlie commented Dec 2, 2024

I will look into this after beta2.

@flurick
Copy link

flurick commented Jan 2, 2025

Slightly related: it looks like flip book groups are not animating either in exported svg

@rodlie
Copy link
Member

rodlie commented Jan 2, 2025

Slightly related: it looks like flip book groups are not animating either in exported svg

Several features in Friction are missing SVG export support. Not sure flipbook makes sense to adapt to SVG.

@pgilfernandez
Copy link
Author

I haven't tested flip books but as @rodlie says this kind of feature is not aligned with web animation ones but it could be done with some time and effort...

@pgilfernandez
Copy link
Author

Hi @rodlie,

Could you help me a little bit? I would like to get to the source of the problem but not able...
I know that the problem is related on how the SVG is built when using visibility range but the curious thing is that the visibility itself is correctly handle in svgexporters.cpp at SvgExportHelpers::assignVisibility.
I have this project:

https://github.com/user-attachments/assets/66da4340-8256-4bd0-85db-ef0ddd92d2f8
svga_visibility_range4.friction.zip

I would say the solution is to find the place it decides to apply another transforms when the visibility range is on and then unable it as it would work properly if it does nothing. The point for saying this is that if the visibility range touches the last frame of the scene, then, it is exported perfectly! but if it doesn't then, the transform of the object is messed up... Pretty odd.

So, this doesn't work:
svga_visibility_range4_visON_wrong
visibility_wrong

And this is how it should be:
svga_visibility_range4_visON_right

But if you do this then it works:
visibility_right

Could you at least help me to figure out where is this happening?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants