Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for ISO 3166 Country A3 Codes & Numeric Codes #10

Open
DevJonie opened this issue Jan 17, 2022 · 1 comment
Open

Support for ISO 3166 Country A3 Codes & Numeric Codes #10

DevJonie opened this issue Jan 17, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@DevJonie
Copy link
Collaborator

Hi everyone,
I'm adding support for A3 codes & Numeric codes.

I'm struggling with a name for the A3 codes field 😅 . Not very good with nomenclature.
The existing A2 code field is named countryShortCode.
Any Ideas?

I was actually thinking of renaming the A2 field to alpha2Code, and name A3 field alpha3Code. Its a breaking change but we've already started breaking things 😅 .

I need ideas 😅
@frankodoom frankodoom added the enhancement New feature or request label Jan 18, 2022
@frankodoom
Copy link
Owner

@DevJonie I pushed the enhancement improvements you made v1.2.0 so i think we can now start looking at the A3 and Numeric Codes, I also created some issues for some nice to have features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frankodoom @DevJonie