Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add easy way to copy scale value from non-editable class/subclass/etc. sheet #4935

Open
JPMeehan opened this issue Dec 28, 2024 · 1 comment · May be fixed by #4983
Open

Add easy way to copy scale value from non-editable class/subclass/etc. sheet #4935

JPMeehan opened this issue Dec 28, 2024 · 1 comment · May be fixed by #4983
Assignees
@arbron
Labels
ui User interface related features or bugs
Milestone
D&D5E 4.2.0

Comments

@JPMeehan
Copy link
Contributor

As a content creator, when I am building a subclass for an existing class I occasionally need to reference a scale value on the base class - the most common case being Monk die and Bardic Inspiration, but others sometimes pop up as well (e.g. Barbarian Rage damage). Currently, copying the scale value's roll data string requires opening the advancement, which is not possible if the sheet is not editable (e.g. it's in the locked SRD classes compendium).

There's already a three dot menu but clicking doesn't do anything currently if the document isn't editable; I think that would be the best place to add some more copy-to-clipboard buttons.
@arbron arbron added the ui User interface related features or bugs label Jan 1, 2025
@arbron
Copy link
Collaborator

arbron commented Jan 1, 2025

I would also make sense to be able to open the advancement configuration app even when the parent item is locked, which can be done right now with activities.

@arbron arbron added this to the D&D5E 4.2.0 milestone Jan 1, 2025
@arbron arbron self-assigned this Jan 10, 2025
arbron added a commit that referenced this issue Jan 10, 2025
@arbron
[#4935] Show advancement context menu when locked
e59dc99 
Moves the advancement context menu configuration from the item
sheet into the `Advancement` class to mimic the activity setup.
In the process adds a "View Advancement" button for when the item
is not editable so the advancement sheet can still be viewed.
arbron added a commit that referenced this issue Jan 10, 2025
@arbron
[#4935] Show advancement context menu when locked
adc46af 
Moves the advancement context menu configuration from the item
sheet into the `Advancement` class to mimic the activity setup.
In the process adds a "View Advancement" button for when the item
is not editable so the advancement sheet can still be viewed.
arbron added a commit that referenced this issue Jan 11, 2025
@arbron
[#4935] Add "Copy Formula" context menu option for scale values
c57e830 
Adds a context menu option for scale value advancement to copy
the @-formula.

Closes #4935
@arbron arbron linked a pull request Jan 11, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbron arbron

Labels
ui User interface related features or bugs
Projects
None yet
Milestone
D&D5E 4.2.0
Development

Successfully merging a pull request may close this issue.

[#4935] Show advancement context menu when locked foundryvtt/dnd5e
2 participants
@JPMeehan @arbron