-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Enchantments to change only damage types #3617
Comments
It would be nice if we could specify which damage field the enchant changes in this case. Ideally a greatsword's slashing damage would be first, so targeting the first "damage field" and changing it to say necrotic would be real useful. |
If possible it would be nice if system.damage.parts.0.1 can be used as an attribute key where the 0 can be any number, on that note have system.damage.parts.0.0 be a key also be nice if only the formula needs changing and use just system.damage.parts to add brand new damage (formula and type). Lastly it would be nice for system.damage.parts.0.0 that things can be added to it, like making a weapon do an extra d6 of damage, where the damage type is the same as the type the weapon already has, so the change mode could be "add" and the effect value could be "+ 1d6" |
Adds the ability for enchantments to replace or add to the damage types for all parts on an activity. This is done using an active effect targeting `system.damage.types`. Using the `OVERRIDE` mode will replace all existing damage types with the specified type, while `ADD` will introduce a new damage type to the existing types. Closes #3617
At the moment it doesnt seem possible to change just the damage type of a weapon using an enchantment which is not ideal for features like elemental cleaver that can infuse a weapon with an element and change the damage type of the weapon (side note it can do so for magic weapons as well like a frost brand weapon, meaning making an enchantment for every weapon type isn't ideal)
The text was updated successfully, but these errors were encountered: