Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all sensors which have been implemented are shown in SensorActivity #2584

Closed
marcnause opened this issue Dec 16, 2024 · 6 comments
Closed

Not all sensors which have been implemented are shown in SensorActivity #2584

marcnause opened this issue Dec 16, 2024 · 6 comments
Assignees
@samruddhi-Rahegaonkar
Labels
Bug Unexpected problem or unintended behavior in app Instrument: Sensors

Comments

@marcnause
Copy link
Contributor

Actual Behaviour

SensorActivity does not list all sensors. (9 sensors are listed.)

Expected Behaviour

SensorActivity should list all available sensors. (11 Actvities for sensors exist.)

The reason why not all sensors are listed is probably that there are duplicate keys in sensorAddr in SensorActivity.

Steps to reproduce it

  1. Open app
  2. Tap "Sensors"
  3. Tap "AUTOSCAN" button

LogCat for the issue

N/A

Screenshots of the issue

Would you like to work on the issue?

Maybe.
@marcnause marcnause added Bug Unexpected problem or unintended behavior in app Instrument: Sensors labels Dec 16, 2024
@samruddhi-Rahegaonkar
Copy link
Contributor

samruddhi-Rahegaonkar commented Dec 17, 2024 •
edited
Loading

@marcnause I would be like to work on this issue.

@marcnause
Copy link
Contributor Author

@samruddhi-Rahegaonkar I have assigned the issue to you. I am not sure what the numbers which are used as keys in in sensorAddr in SensorActivity mean.

@AsCress You probably added the new sensor implementations during GSoC. Do you remember where the numbers come from?

@samruddhi-Rahegaonkar
Copy link
Contributor

@marcnause Solved !👍

@samruddhi-Rahegaonkar
Copy link
Contributor

@marcnause Solved Not all sensors which have been implemented are shown in SensorActivity #2584
Screenshot 2024-12-18 at 1 33 13 PM
All Sensors are showing.

samruddhi-Rahegaonkar added a commit to samruddhi-Rahegaonkar/pslab-android that referenced this issue Dec 18, 2024
@samruddhi-Rahegaonkar
Fix: Display all implemented sensors in SensorActivity fossasia#2584
1c27f92
@samruddhi-Rahegaonkar
Copy link
Contributor

@marcnause Hi, I have submitted a PR #2589 that resolves this issue. Please let me know if further changes are needed. Thanks!

@AsCress AsCress mentioned this issue Dec 21, 2024
Merged
marcnause pushed a commit that referenced this issue Jan 9, 2025
@samruddhi-Rahegaonkar @AsCress
fix: Display all implemented sensors in SensorActivity #2584 (#2589)
4e8938b 
Co-authored-by: Anashuman Singh <[email protected]>
Co-authored-by: Anashuman Singh <[email protected]>
@AsCress
Copy link
Collaborator

AsCress commented Jan 11, 2025

Completed in #2589.

@AsCress AsCress closed this as completed Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samruddhi-Rahegaonkar samruddhi-Rahegaonkar

Labels
Bug Unexpected problem or unintended behavior in app Instrument: Sensors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marcnause @samruddhi-Rahegaonkar @AsCress