Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always spell +mongo-port+ using the same case #18

Open
avodonosov opened this issue Dec 9, 2013 · 0 comments
Open

always spell +mongo-port+ using the same case #18

avodonosov opened this issue Dec 9, 2013 · 0 comments

Comments

@avodonosov
Copy link

cl-mongo has a constant +mongo-port+ which is spelled using different cases in the source code.

;; mongo.lisp

(defconstant +mongo-port+ 27017)
  ;;...
(defvar *mongo-default-port* +MONGO-PORT+ "port for the default connection.")
  ;; ...
(defun switch-default-connection (name &key (host "localhost") (db "test") (port +MONGO-PORT+))
  ;; ...
  )

This should not be a problem in the default reader mode.

But when we recompile all the dependencies, this causes a problem on ECL.
I reported it as an ECL bug: https://sourceforge.net/p/ecls/bugs/279/

Still, it will be nice if cl-mongo had a workaround for ECL, but always using capitalized
variang, i.e. change (defconstant +mongo-port+ 27017) to (defconstant +MONGO-PORT+ 27017)

Doing so will also be friendly to Allegro CL modern mode and other cases when lisp reader does not convert all symbols to a single case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant