Make it possible to add resources with `classpath:` prefix #216

lowcasz · 2023-10-05T20:49:34Z

I can't generate pdf using externally loaded css stylesheet. It is generate without any styles.
Images with classpath prefix are not loaded too.
Everything works when I specify absolute path to file (with prefix file://), but this is not acceptable in my app.

My code:

final ITextRenderer renderer = new ITextRenderer();
renderer.setDocumentFromString(html);
renderer.getFontResolver().addFontDirectory(properties.fonts(), EMBEDDED);
renderer.layout();
final ByteArrayOutputStream pdf = new ByteArrayOutputStream();
renderer.createPDF(pdf);
write(properties.output(), pdf.toByteArray());

My HTML:

<html lang="pl-PL">
<head>
    <title>Title</title>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
    <meta http-equiv="Content-Language" content="pl-PL"/>
    <link href="classpath:templates/css/stylesheet.css" rel="stylesheet" type="text/css" media="print"/>
</head>
<body>...</body>
</html>

My maven dependecies:

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <parent>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-starter-parent</artifactId>
        <version>3.1.4</version>
        <relativePath/> <!-- lookup parent from repository -->
    </parent>
    <groupId>com.example</groupId>
    <artifactId>pdf-generator</artifactId>
    <version>1.0.0-SNAPSHOT</version>
    <name>pdf-generator</name>
    <description>pdf-generator</description>
    <properties>
        <java.version>17</java.version>
    </properties>
    <dependencies>
        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-thymeleaf</artifactId>
        </dependency>
        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-configuration-processor</artifactId>
            <optional>true</optional>
        </dependency>
        <dependency>
            <groupId>org.projectlombok</groupId>
            <artifactId>lombok</artifactId>
            <optional>true</optional>
        </dependency>
        <dependency>
            <groupId>com.fasterxml.jackson.core</groupId>
            <artifactId>jackson-databind</artifactId>
        </dependency>
        <dependency>
            <groupId>org.xhtmlrenderer</groupId>
            <artifactId>flying-saucer-pdf-openpdf</artifactId>
            <version>9.3.1</version>
        </dependency>
    </dependencies>
    <build>
        <plugins>
            <plugin>
                <groupId>org.springframework.boot</groupId>
                <artifactId>spring-boot-maven-plugin</artifactId>
                <configuration>
                    <excludes>
                        <exclude>
                            <groupId>org.projectlombok</groupId>
                            <artifactId>lombok</artifactId>
                        </exclude>
                    </excludes>
                </configuration>
            </plugin>
        </plugins>
    </build>
</project>

asolntsev · 2023-10-05T21:22:20Z

@lowcasz Did it ever work? Do you mean that FlyingSaucer did load resources from classpath, and this feature was broken with some release? Or it never really worked, and you just wish such a feature?

lowcasz · 2023-10-06T11:13:37Z

It was worked on my other project.
HTML is copied from old project for test, it was work there.
I don't see any other configuration and configuration classes between them.
In old project is older version of saucer. (9.1.22)

pbrant · 2023-10-06T11:19:39Z

Some frameworks will supply a classpath:// URL handler. See e.g. https://stackoverflow.com/questions/861500/url-to-load-resources-from-the-classpath-in-java. We've done something similar internally before. Could that be why it worked before? I don't think this is something that FS has supplied out of the box though.

…

On Fri, Oct 6, 2023 at 1:13 PM Cezary Hadrzyński ***@***.***> wrote: It was worked on my other project. — Reply to this email directly, view it on GitHub <#216 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF42FAAXLXT4DB3WVO7S3X57RWZAVCNFSM6AAAAAA5U3E442VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQGQZTMMJRGM> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

lowcasz · 2023-10-06T11:28:01Z

I don't know, maybe...
Do you know any dependency, especially spring dependency which can do it in background?
It can helps me to find it, I don't see any additional parameters, configuration or classes which do it.

pbrant · 2023-10-06T11:48:34Z

I do not, I'm afraid.

…

On Fri, Oct 6, 2023 at 1:28 PM Cezary Hadrzyński ***@***.***> wrote: I don't know, maybe... Do you know any dependency, especially spring dependency which can do it in background? It can helps me to find it, I don't see any additional parameters, configuration or classes which do it. — Reply to this email directly, view it on GitHub <#216 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF42EOC7HEPBEXOGL4NODX57TMZAVCNFSM6AAAAAA5U3E442VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQGQ3DQOJZG4> . You are receiving this because you commented.Message ID: ***@***.***>

now it's possible to use "classpath:" prefix in URLs of included resources, e.g. ``` <link href="classpath:styles/sample.css"/> ```

asolntsev · 2023-12-28T21:35:26Z

@lowcasz implemented in #241, released version 9.3.2 today.

andrzej-talarek · 2023-12-31T05:20:25Z

Funny thing, but in my case it worked perfectly fine (classpath:/static/css/custom.css) in 9.3.1 version and broke with 9.3.2 :(. It's broken both for bootJar task, that I'm using for system development usually and normal building jar for running it with java -jar. Can't upgrade.

2023-12-31 06:18:15.880 ERROR -  o.a.j.l.DirectJDKLog : Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Request processing failed: java.lang.NullPointerException: Cannot invoke "java.net.URL.toString()" because "resource" is null] with root cause
java.lang.NullPointerException: Cannot invoke "java.net.URL.toString()" because "resource" is null
	at org.xhtmlrenderer.swing.NaiveUserAgent.resolveURI(NaiveUserAgent.java:370)
	at org.xhtmlrenderer.context.StyleReference.getStylesheets(StyleReference.java:224)
	at org.xhtmlrenderer.context.StyleReference.setDocumentContext(StyleReference.java:85)
	at org.xhtmlrenderer.pdf.ITextRenderer.setDocument(ITextRenderer.java:183)
	at org.xhtmlrenderer.pdf.ITextRenderer.setDocument(ITextRenderer.java:144)
	at org.xhtmlrenderer.pdf.ITextRenderer.setDocumentFromString(ITextRenderer.java:167)
	at org.xhtmlrenderer.pdf.ITextRenderer.setDocumentFromString(ITextRenderer.java:160)

asolntsev · 2024-01-01T01:22:37Z

@andrzej-talarek Thank you for the feedback.
First of all, I assume that FS 9.3.1 didn't really load custom.css file, but just silently ignored it.
And FS 9.3.2 started searching this file in classpath and complaining if the file cannot be found.

Are you sure you have folder static in the classpath?

If yes, how can I reproduce the problem? Could you create a simple reproducible example?

andrzej-talarek · 2024-01-01T06:00:20Z

I'm 100% sure it worked fine - I've used several included styles (custom ones and bootstrap styles) and I know styles worked OK then (looking at final pdf).
Since it's spring-boot app, I'm not sure it would be that easy, but I can try to prepare a repo with as little code as it only requires.

pbrant · 2024-01-03T16:18:47Z

@andrzej-talarek This should be fixed in #250.

asolntsev · 2024-01-07T01:02:23Z

@andrzej-talarek The fix #250 has been released as FlyingSaucer 9.4.1
Can you please check if it helps?

andrzej-talarek · 2024-01-07T04:32:59Z

Confirmed, works perfectly again :-). Great thanks @asolntsev !

asolntsev added the feature label Oct 5, 2023

asolntsev added this to the 9.3.2 milestone Dec 28, 2023

asolntsev self-assigned this Dec 28, 2023

asolntsev added a commit that referenced this issue Dec 28, 2023

#216 implement loading resources from classpath

6f192ab

now it's possible to use "classpath:" prefix in URLs of included resources, e.g. ``` <link href="classpath:styles/sample.css"/> ```

asolntsev linked a pull request Dec 28, 2023 that will close this issue

#216 implement loading resources from classpath #241

Merged

asolntsev changed the title ~~I can't add resources with classpath prefix~~ Make it possible to add resources with classpath: prefix Dec 28, 2023

asolntsev closed this as completed in #241 Dec 28, 2023

asolntsev added a commit that referenced this issue Dec 28, 2023

#216 implement loading resources from classpath

c6571da

now it's possible to use "classpath:" prefix in URLs of included resources, e.g. ``` <link href="classpath:styles/sample.css"/> ```

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make it possible to add resources with `classpath:` prefix #216

Make it possible to add resources with `classpath:` prefix #216

lowcasz commented Oct 5, 2023 •

edited by asolntsev

Loading

asolntsev commented Oct 5, 2023

lowcasz commented Oct 6, 2023 •

edited

Loading

pbrant commented Oct 6, 2023 via email

lowcasz commented Oct 6, 2023

pbrant commented Oct 6, 2023 via email

asolntsev commented Dec 28, 2023 •

edited

Loading

andrzej-talarek commented Dec 31, 2023

asolntsev commented Jan 1, 2024

andrzej-talarek commented Jan 1, 2024

pbrant commented Jan 3, 2024

asolntsev commented Jan 7, 2024

andrzej-talarek commented Jan 7, 2024

Make it possible to add resources with classpath: prefix #216

Make it possible to add resources with classpath: prefix #216

Comments

lowcasz commented Oct 5, 2023 • edited by asolntsev Loading

asolntsev commented Oct 5, 2023

lowcasz commented Oct 6, 2023 • edited Loading

pbrant commented Oct 6, 2023 via email

lowcasz commented Oct 6, 2023

pbrant commented Oct 6, 2023 via email

asolntsev commented Dec 28, 2023 • edited Loading

andrzej-talarek commented Dec 31, 2023

asolntsev commented Jan 1, 2024

andrzej-talarek commented Jan 1, 2024

pbrant commented Jan 3, 2024

asolntsev commented Jan 7, 2024

andrzej-talarek commented Jan 7, 2024

Make it possible to add resources with `classpath:` prefix #216

Make it possible to add resources with `classpath:` prefix #216

lowcasz commented Oct 5, 2023 •

edited by asolntsev

Loading

lowcasz commented Oct 6, 2023 •

edited

Loading

asolntsev commented Dec 28, 2023 •

edited

Loading