Allow archiving to be disabled

fly-apps · Jun 25, 2024 · b859216 · b859216
1 parent 2d4b622
commit b859216
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/internal/flypg/pg.go b/internal/flypg/pg.go
@@ -173,7 +173,8 @@ func (c *PGConfig) SetDefaults() error {
 	}
 
 	// Works to configure archiving to object storage if enabled
-	if os.Getenv("CLOUD_ARCHIVING_ENABLED") == "true" {
+	switch os.Getenv("CLOUD_ARCHIVING_ENABLED") {
+	case "true":
 		if err := validateCloudArchiver(); err != nil {
 			return fmt.Errorf("failed to validate s3 archiver: %s", err)
 		}
@@ -184,6 +185,11 @@ func (c *PGConfig) SetDefaults() error {
 		archiveCommand := fmt.Sprintf("'barman-cloud-wal-archive --cloud-provider aws-s3 --endpoint-url %s s3://%s %s %%p'", endpoint, bucket, c.AppName)
 		c.internalConfig["archive_mode"] = "on"
 		c.internalConfig["archive_command"] = archiveCommand
+	case "false":
+		c.internalConfig["archive_mode"] = "off"
+	default:
+		// Noop to remain backwards compatible with existing setups that may have
+		// manually setup archiving.
 	}
 
 	return nil