Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make envsubst callable (add main) #851

Open
guettli opened this issue Jan 8, 2025 · 4 comments
Open

Make envsubst callable (add main) #851

guettli opened this issue Jan 8, 2025 · 4 comments

Comments

@guettli
Copy link

guettli commented Jan 8, 2025

Thank you very much for incorporating my PR to the upstream (unmaintained) envsubst: drone/envsubst#34

I notice that you do not provide a main package, so the package is not callable as a binary.

What about adding a main, so that we can install a binary via go install?

I could provide a PR, but I guess you fill do it fast, so feel free to do it, if you think it is useful.

@stefanprodan
Copy link
Member

You can use flux envsubst, the Flux CLI is available for all platforms and as a container image, see https://fluxcd.io/flux/installation/#install-the-flux-cli

@guettli
Copy link
Author

guettli commented Jan 8, 2025

@stefanprodan Cluster API uses the unmaintained envsubst a lot. I think the capi maintainers don't want depend on the flux command line tool.

@stefanprodan
Copy link
Member

The fluxcd/pkg repo is for Go packages, having some command/exec project in here is not feasible. You could create a repo in Cluster API and implement there a standalone CLI that import fluxcd/pkg/envsubst.

@guettli
Copy link
Author

guettli commented Jan 8, 2025

@stefanprodan thank you for your reply. Yes, your suggestion is a good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants