Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a JGF reader to populate the resource graph data store #444

Closed
dongahn opened this issue Feb 20, 2019 · 2 comments
Closed

Need a JGF reader to populate the resource graph data store #444

dongahn opened this issue Feb 20, 2019 · 2 comments

Comments

@dongahn
Copy link
Member

dongahn commented Feb 20, 2019

No description provided.

@dongahn
Copy link
Member Author

dongahn commented Sep 18, 2019

Just had a discussion with @milroy and @SteVwonder:

The current plan is to rename generators into readers and refactor the current flat class structure into a two-level hierarchy -- resource_reader_base_t as the base class and resource_reader_grug_t, resource_reader_hwloc_t, and resource_reader_jgf_t as derived classes. I will also use a factory class pattern to help the upper layer written with the base reader class as much as possible.

Then, I will add one method called load into resource_graph_db_t, which takes in a base reader object and a serialized string as input and newly populates its resource graph.

Expanding this, @milroy will further extend resource_graph_db_t with additional grow and shrink methods in support of #511 and later elastic scheduling.

@dongahn
Copy link
Member Author

dongahn commented Sep 22, 2019

resource_graph_db_t will be carved out from resource/schema subdirectory to its own subdirectory called resource/store. Two advantages: 1) We don't want to create an additional dependency into schema -- in fact it will create a circular dependency between schema and readers; 2) as resource_graph_db_t will be extended in the future for elastic scheduling support, we don't want to keep this as a headerfile only implementation, but rather treat this as a first class citizen: its own header and implementation files.

@dongahn dongahn closed this as completed Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant