Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify logging to only use Flux logging #44

Open
ilumsden opened this issue Sep 7, 2023 · 2 comments
Open

Unify logging to only use Flux logging #44

ilumsden opened this issue Sep 7, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@ilumsden
Copy link
Collaborator

ilumsden commented Sep 7, 2023

Right now, we have 3 mechanisms to log information in DYAD:

  • DYAD_LOG_INFO, DYAD_LOG_ERR, FLUX_LOG_INFO, FLUX_LOG_ERR (i.e., Flux logging)
  • DPRINTF
  • IPRINTF

We should unify these approaches together into a single approach. I'd recommend that we use the first approach (i.e., DYAD_LOG_INFO, etc.) for this.

@JaeseungYeom
Copy link
Contributor

We are almost there.
We currently support flux based logging, cpp-logger library based logging, and stdout/stderr.
However, the last one is folded into Flux-based logging. This should be fixed.
The last case has unique advantage where it does not rely on any other infrastructure. So, it is easier for unit testing, and utility code.

@wangvsa
Copy link
Collaborator

wangvsa commented Dec 10, 2024

Do we want to keep all three loggers: FLUX, CPP and PRINTF?
Currently, setting "-DDYAD_LOGGER=PRINTF" will cause compile errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants