We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The JSDoc for the stdoutLines property is string but appears to accept a number.
string
JSDoc: https://github.com/fluent-ffmpeg/node-fluent-ffmpeg/blob/master/lib/fluent-ffmpeg.js#L27
Implementation: https://github.com/fluent-ffmpeg/node-fluent-ffmpeg/blob/master/lib/fluent-ffmpeg.js#L65
options.stdoutLines = 'stdoutLines' in options ? options.stdoutLines : 100;
Since the default of 100 is a number, it makes sense to me that stdoutLines's type should also be number.
100
stdoutLines
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
The JSDoc for the stdoutLines property is
stringbut appears to accept a number.JSDoc:
https://github.com/fluent-ffmpeg/node-fluent-ffmpeg/blob/master/lib/fluent-ffmpeg.js#L27
Implementation:
https://github.com/fluent-ffmpeg/node-fluent-ffmpeg/blob/master/lib/fluent-ffmpeg.js#L65
options.stdoutLines = 'stdoutLines' in options ? options.stdoutLines : 100;Since the default of
100is a number, it makes sense to me thatstdoutLines's type should also be number.The text was updated successfully, but these errors were encountered: