Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on old nodejs: 'async' dependency version not fixed #938

Open
Chnapy opened this issue Aug 17, 2019 · 0 comments
Open

Crash on old nodejs: 'async' dependency version not fixed #938

Chnapy opened this issue Aug 17, 2019 · 0 comments

Comments

@Chnapy
Copy link

Chnapy commented Aug 17, 2019

Hi,

I have a project using nodejs 4 which use fluent-ffmpeg ^2.0.1.
It worked like a charm until that a README fix broke my Travis.

image

It crash on the require('fluent-ffmpeg').

Stacktrace:

/.../node_modules/async/dist/async.js:52
    function apply(fn, ...args) {
                       ^^^

SyntaxError: Unexpected token ...
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:387:25)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Module.require (module.js:367:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/.../node_modules/fluent-ffmpeg/lib/processor.js:7:13)

It crash like this with nodejs 4 and 5. But it works with nodejs 8, 9, and 11. I didn't test with other versions.
After a little investigation I saw that the async dependency version in the package.json is definitely in freewheel !

"async": ">=0.2.9",

Actually, when I look to my async version in my node_modules, it's 3.1.0 !

It's not safe to let a dependency change major version. I now have an app which worked before and not anymore without changing anything in its code.

@Chnapy Chnapy changed the title 'async' dependency version not fixed Crash on old nodejs: 'async' dependency version not fixed Aug 17, 2019
Chnapy added a commit to Chnapy/youtube-album-uploader-multiple that referenced this issue Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant