Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing documentation about the end event and screenshots/thumbnails and filenames event #846

Open
zya opened this issue Sep 7, 2018 · 0 comments

Comments

@zya
Copy link

zya commented Sep 7, 2018

In the docs there is this section:


'end': processing finished

The end event is emitted when processing has finished. Listeners receive ffmpeg standard output and standard error as arguments, except when generating thumbnails (see below), in which case they receive an array of the generated filenames.

ffmpeg('/path/to/file.avi')
  .on('end', function(stdout, stderr) {
    console.log('Transcoding succeeded !');
  });

stdout is empty when the command outputs to a stream. Both stdout and stderr are limited by the stdoutLines option (defaults to 100 lines).


The confusion is about the expected behaviour when generating thumbnails. In the examples here, there seems to be an event called filenames which returns you the list of filenames. In this documentation, it is mentioned that the stout and stderr will be replaced with the filenames when generating thumbnails.
I have not been able to replicate this. As in, even in success cases, the callback arguments are not an array of filenames. And in failure cases, we seem to get stout and stderr as expected.
Is this a mistake in documentation? Or am I understanding the expected behaviour wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant