Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate pnpm lint:fix #71

Open
florian-lefebvre opened this issue Feb 29, 2024 · 3 comments
Open

Automate pnpm lint:fix #71

florian-lefebvre opened this issue Feb 29, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@florian-lefebvre
Copy link
Owner

Right now it's not a great contribution experience to require contributors (especially first time ones) to run pnpm lint:fix. It would be great to have an action that runs on main and does this. I recommend we use autofix-ci for this (I think an example can be found on nuxt repo)

@florian-lefebvre florian-lefebvre added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Feb 29, 2024
@Fryuni
Copy link
Collaborator

Fryuni commented Mar 1, 2024

I have a nifty workflow on some repos at work that I think would be great here. A "check meargeability" job requires reviews and labels, so nothing can be merged without them. The last label it requires is a ready-for-merge and that formats and commits in the PR itself.

Works fine for branches in the repo, but for forks I think it requires the "allow maintainer edits", which is on by default but users can disable it.

@florian-lefebvre
Copy link
Owner Author

Sounds good! I'd love this

@ITZSHOAIB
Copy link
Contributor

#122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants