Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper imports in the node ecosystem (tldr; add .js everywhere) #7

Open
florian-lefebvre opened this issue Jan 22, 2024 · 4 comments
Open

Comments

@florian-lefebvre
Copy link
Owner

Reference: https://discord.com/channels/830184174198718474/1197638002764152843/1199038311319224420

@natemoo-re
Copy link

(Not so) hot take: every Astro integration should be published only as ESM. There's absolutely no reason to compile an integration to CJS.

@florian-lefebvre
Copy link
Owner Author

Sure we'll specify that! I was just referencing the .js discussion with Erika but ran out of ideas for this issue name xd

@florian-lefebvre florian-lefebvre changed the title [guide] proper imports in cjs/esm hell Proper imports in the node ecosystem (tldr; add .js everywhere) Jan 23, 2024
@jdtjenkins
Copy link
Collaborator

@florian-lefebvre can this close now then?

@florian-lefebvre
Copy link
Owner Author

Nope! I don't know if you saw the label but this is for guides! When we start writing documentation about how to write integrations start to finish, we'll need to talk about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants