Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bic instead of and on arm for clang compatibility #3

Open
krovetz opened this issue Jun 20, 2015 · 0 comments
Open

Use bic instead of and on arm for clang compatibility #3

krovetz opened this issue Jun 20, 2015 · 0 comments

Comments

@krovetz
Copy link

krovetz commented Jun 20, 2015

Hello Andrew,

I'm using your chacha implementation for a project and thought I'd report a very small issue.

Because the constants are too big for and, gcc is nice enough to assemble and sp, sp, #0xffffffe0 into the equivalent bic sp, sp, #31 and and sp, sp, #0xffffff80 into the equivalent bic sp, sp, #127. Clang however doesn't. Changing the source to use bic would make the code work on both compilers.

Thanks for the nice implementations!

Ted Krovetz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant