Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShUp: query pacs with patient IPP produces wrong tree (all exams, but no series) #1978

Closed
michaelkain opened this issue Dec 12, 2023 · 5 comments
Assignees

Comments

@michaelkain
Copy link
Contributor

michaelkain commented Dec 12, 2023

ShUp provides an interface to query a PACS (DICOM server), when using patient name and study date, all works fine. When using the patient IPP as search criteria, the tree is strange: shows all exams, but misses series). This should be fixed on the code of #1930 (the latest version).
seen with CH

@michaelkain michaelkain self-assigned this Dec 12, 2023
@michaelkain michaelkain changed the title ShUp: query pacs with patientIPP produces wrong tree (all exams, but no series) ShUp: query pacs with patient IPP produces wrong tree (all exams, but no series) Dec 12, 2023
@michaelkain michaelkain assigned LaurentPV and unassigned michaelkain Dec 12, 2023
@michaelkain
Copy link
Contributor Author

Hi Laurent, to fix this issue, you will have to use, what is currently on my branch ShUp v8.0.0, the latest version. I have put you reviewer on my PR. To see, what I did. I did a refactor, that was quite hard to do, to remove the old DICOM library dcm4che2 from ShUp, to migrate to dcm4che3 and use the same code as the server to query the pacs. It works now fine, after weeks of fixes, in one center. There seems to remain the problem with the pacs query on using patient IPP. This might be a good start for you, to dive into DICOM query. And to set up locally a PACS from which you can import, on using the new code with dcm4che3. With kind regards, Michael

@michaelkain
Copy link
Contributor Author

Please see this guide here to use the backup pacs behind shanoir server, as your import pacs
https://github.com/fli-iam/shanoir-ng/wiki/Developer-testing-c%E2%80%90move

@LaurentPV
Copy link
Contributor

Can you give an example of patient's name or ID where you have the problem ? I am testing with the datasets I have on local and cannot reproduce the anomaly.(ps : I am on your branch).
I have the same outputs if I search on ShUp with only the Name of the patient or the ID of the Patient, maybe because my dataset is only one examination.

Also, when searching with the name and the date of the study I have this error :
Capture d’écran 2023-12-22 à 17 13 56

@michaelkain
Copy link
Contributor Author

Hi Laurent, thank you for your efforts. On local it always worked for me as well.
I fixed it now, as confirmed by CH. I think the problem was, that I searched for
series with the StudyInstanceUID only, but some Pacs "prefers" studyDate as well.
I added it now it is solved. Thank you and with kind regards, Michael
PS: solution on my PR open-in-view

@michaelkain
Copy link
Contributor Author

Fix here: in QueryPACSService: #2063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants