Collected code questions and comments

[gitkief]

1. dewret/src/dewret/tasks.py

   Line 208 in 68ef970

   __workflow__: Workflow | None = None,

   Why does the parameter has this dunder naming and not just workflow?

2. dewret/src/dewret/renderers/cwl.py

   Line 777 in 68ef970

   lambda workflow: WorkflowDefinition.from_workflow(workflow).render(),

   At first glance, without thinking too much about it, I thought WorkflowDefinition.from_workflow(workflow).render() is already executed for the input argument workflowof the render function. So while technically correct (of course) maybe renaming the lambda argument is clearer. Similar for the snakemake renderer.

3. dewret/src/dewret/workflow.py

   Line 521 in 68ef970

   ref._.parameter for ref in references if isinstance(ref, ParameterReference)

   Having a variable/attribute being reused just named _ feels awkward. Is there no better name?

4. dewret/src/dewret/core.py

   Lines 305 to 311 in 68ef970

   	return ConstructConfiguration(
   	flatten_all_nested=False,
   	allow_positional_args=False,
   	allow_plain_dict_fields=False,
   	field_separator="/",
   	field_index_types="int",
   	)

   Basically repeats the default arguments of the class definition . Why? In addition, in
   

   dewret/src/dewret/core.py

   Line 262 in 68ef970

   construct=ConstructConfiguration(), render=default_renderer_config()

   
   the default values for construct are fetched from the ConstructConfiguration class init as compared to the render settings. I.e. default_construct_config seems superfluous at this point.

5. dewret/src/dewret/__main__.py

   Line 146 in 68ef970

   render = get_render_method(render_module, pretty=pretty)

   Could we rename the method here to render_method etc. to avoid shadowing of the main render function?