-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make data.json available in analysis scripts #238
Comments
Would moving to virtual file systems suggest that we should also revise the state model for those files in the reducer? Instead of keeping 2 copies in memory? |
This would be something which is local to the runtime environment set-up for the scripts (e.g., inside the pyodide worker). It arguably would be the wrong thing to do to unify this with the state model, since we explicitly would not want edits in the data to be visible in the analysis script if the sampler isn't re-run first |
Why not make it available as a data variable, as in the data generation scripts? Maybe I'm missing exactly what you are proposing. |
We could try. I think that solution would require more work, for ultimately not much gain.
|
Okay makes sense. |
It is often useful to analyze the results in the context of the data. The example we provide for the SIR model already does this by re-installing the package the data came from, but a more general solution would be to have the data.json available in the script. This style would also compose well with #179
We can do this with virtual file systems:
The text was updated successfully, but these errors were encountered: