Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bouncing between plotly and ns plots does not save the plot state #270

Open
bendichter opened this issue Feb 24, 2025 · 6 comments
Open

Comments

@bendichter
Copy link
Contributor

See how the start time changes:

Screen.Recording.2025-02-24.at.11.48.28.AM.mov

https://neurosift.app/nwb?url=https://api.dandiarchive.org/api/assets/8e55b7ac-a085-43c0-9dc9-c577bcbe1824/download/&dandisetId=000409&dandisetVersion=draft&tab=/units

@magland
Copy link
Collaborator

magland commented Feb 25, 2025

@bendichter I don't see the start time changing. Could you explain a bit more?

@bendichter
Copy link
Contributor Author

When you switch from a NS native plot to a plotly plot, the plotly plot should have the same controls (in this case unit and time selection) as the NS native plot. Otherwise, as soon as you switch there is an inconsistency between the controls and the plot.

@magland
Copy link
Collaborator

magland commented Feb 25, 2025

I still don't get it. In your video I don't see any of the controls changing.

@bendichter
Copy link
Contributor Author

bendichter commented Feb 25, 2025

When the video starts, the time window of the plot starts at 25 seconds (despite the fact that the time controls say 85). Then when I change to the plotly plot type, the start time of the window jumps to 85. Then when I click again the NS plot appears and the time range is back to starting at 25. I think the plot should always be consistent with the controls and that it the time window should remain consistent when you switch between plot types

@magland
Copy link
Collaborator

magland commented Feb 25, 2025

Oh I see, thanks for the explanation.

Actually the time range is always consistent with the controls ... the deceptive thing is that in the native NS plot, the time axis labels can be misleading. So when it says 25, it really means 1 minute and 25 seconds. The 1 minute is not shown. I made it this way so that when you zoom in you see things like 230 ms, 235 ms, etc... without having all the all 5 hrs, 23 min, 5 sec, 230 ms. I'm not sure what is the best way to display this to have the best of all worlds.

So this is an issue, but it's not what you are describing.

(Also, the units get flipped vertically which may be contributing to the confusion - I'll create a new issue for that).

@bendichter
Copy link
Contributor Author

ah ok yes thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants