Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fund accounts in setup from passed prv. key #68

Closed
zeroXbrock opened this issue Jan 4, 2025 · 1 comment
Closed

fund accounts in setup from passed prv. key #68

zeroXbrock opened this issue Jan 4, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@zeroXbrock
Copy link
Member

zeroXbrock commented Jan 4, 2025

When passing a private key with -p to contender setup, make sure the from addresses in the [[setup]] stages and [[create]] stages are funded by the passed key.

If you're using a hard-coded from address, it will not be funded. However, from_pool addresses are funded.

@zeroXbrock zeroXbrock added enhancement New feature or request good first issue Good for newcomers labels Jan 8, 2025
@zeroXbrock
Copy link
Member Author

this issue is not quite as pressing, or even relevant now, since from should now generally be replaced by from_pool. (#72, #65)

Specifying a from address in a setup step implies that the account will always be funded prior to running contender, which is usually not the case, namely when testing any network that isn't a local devnet.

I'd actually like to disincentivise the use of from in general, since from_pool works so well.
from addresses in builtin scenarios should be phased out immediately.

We could even remove the existing from functionality entirely, and rename from to act as from_pool (and remove from_pool). There really isn't any need to include hard-coded from addresses in scenario configs, as long as you want them to be portable (used by anyone other than you).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant