From fde80ff48913904b563c244cd09539426d520b3d Mon Sep 17 00:00:00 2001 From: Jamie <31554168+flaree@users.noreply.github.com> Date: Thu, 20 Feb 2025 12:01:16 +0000 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- ballsdex/core/models.py | 2 ++ ballsdex/packages/admin/money.py | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/ballsdex/core/models.py b/ballsdex/core/models.py index 49d04593..110f1f79 100755 --- a/ballsdex/core/models.py +++ b/ballsdex/core/models.py @@ -461,6 +461,8 @@ async def is_blocked(self, other_player: "Player") -> bool: return await Block.filter((Q(player1=self) & Q(player2=other_player))).exists() async def add_money(self, amount: int) -> int: + if amount <= 0: + raise ValueError("Amount to add must be positive") self.money += amount await self.save(update_fields=("money",)) return self.money diff --git a/ballsdex/packages/admin/money.py b/ballsdex/packages/admin/money.py index 44711d28..70e12953 100644 --- a/ballsdex/packages/admin/money.py +++ b/ballsdex/packages/admin/money.py @@ -26,7 +26,7 @@ async def balance(self, interaction: discord.Interaction[BallsDexBot], user: dis player = await Player.get_or_none(discord_id=user.id) if not player: await interaction.followup.send( - f"This user has does not have a {settings.bot_name} account.", ephemeral=True + f"This user does not have a {settings.bot_name} account.", ephemeral=True ) return @@ -52,7 +52,7 @@ async def add( player = await Player.get_or_none(discord_id=user.id) if not player: await interaction.followup.send( - f"This user has does not have a {settings.bot_name} account.", ephemeral=True + f"This user does not have a {settings.bot_name} account.", ephemeral=True ) return @@ -90,7 +90,7 @@ async def remove( player = await Player.get_or_none(discord_id=user.id) if not player: await interaction.followup.send( - f"This user has does not have a {settings.bot_name} account.", ephemeral=True + f"This user does not have a {settings.bot_name} account.", ephemeral=True ) return