Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meaningless sounds get produced randomly if there are continuous spaces(newlines, tabs) regardless of prompts or input content #765

Open
6 tasks done
AndyRightNow opened this issue Dec 17, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@AndyRightNow
Copy link

Self Checks

  • This template is only for bug reports. For questions, please visit Discussions.
  • I have thoroughly reviewed the project documentation (installation, training, inference) but couldn't find information to solve my problem. English 中文 日本語 Portuguese (Brazil)
  • I have searched for existing issues, including closed ones. Search issues
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • [FOR CHINESE USERS] 请务必使用英文提交 Issue,否则会被关闭。谢谢!:)
  • Please do not modify this template and fill in all required fields.

Cloud or Self Hosted

Self Hosted (Source)

Environment Details

Ubuntu 22.04.3 LTS (Google Colab), Python 3.10, torch==2.4.1

Steps to Reproduce

Run tools/llama/generate.py with any Chinese text that has continuous whitespaces, such as indentations, and with any prompts.

For example:

    要转换的文本。
    要转换的文本?
    要转换的文本。
    “要转换的文本!”
    要转换的文本。

Note that if the indents at the beginning each line get removed, the random meaningless sounds also disappear. Also the meaningless sounds don't always appear on every line. It happens periodically and has no specific patterns.

Right now my workaround is to add an additional clean-up step here inside clean_text

def clean_text(text):

to replace any continuous whitespace characters with the first occurrence of the matched characters (including newlines or tabs).

✔️ Expected Behavior

No random meaningless sounds.

❌ Actual Behavior

As described above.

@AndyRightNow AndyRightNow added the bug Something isn't working label Dec 17, 2024
@basitcodeenv
Copy link

+1

1 similar comment
@talaon2
Copy link

talaon2 commented Jan 6, 2025

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants