Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: explicit signatures #167

Open
erhant opened this issue Jan 10, 2025 · 2 comments · May be fixed by #173
Open

feat: explicit signatures #167

erhant opened this issue Jan 10, 2025 · 2 comments · May be fixed by #173

Comments

@erhant
Copy link
Member

erhant commented Jan 10, 2025

Currently we have two types of signed payloads:

  • Task response is given with {encryption, signature} and the object itself is sent in plain
  • Other signed messages are prepared as signature_bytes || message_bytes where parsing it is a bit more byte-manipulation instead of simple JSON-parse & read field.

We should unify all this and simply work with JSON formats.

@erhant
Copy link
Member Author

erhant commented Jan 16, 2025

We decide on {data, sig} JSON instead for all repsonses.

@erhant erhant linked a pull request Jan 24, 2025 that will close this issue
11 tasks
@erhant
Copy link
Member Author

erhant commented Jan 24, 2025

We will add signature and recovery_id to DriaMessage struct. Furthermore, the signed data will change from SHA256(decoded_payload) to SHA256(payload) in DriaMessage which simplifies the code & saves one extra decoding step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant