Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: request-response for spec-sharing #163

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

feat: request-response for spec-sharing #163

wants to merge 12 commits into from

Conversation

erhant
Copy link
Member

@erhant erhant commented Dec 27, 2024 •
edited
Loading

  • Added a separate handler/channel for non-gossipsub messages (i.e. request-response stuff) based on https://github.com/libp2p/rust-libp2p/tree/master/examples/file-sharing
  • Added request handler with peer-id check so that only RPC nodes can make a request
  • Added an error log if the last time a ping was received is too long ago
  • Changed "task ignored due to filter" log level from info to debug
  • Changed behavior ordering, to tackle bug: crash in debug modes #158 but it didnt work*
  • Changed gossipsub message received log positions
    • a ping message now shows the uuid as well
    • a task message is logged only if its a valid task & node is in the filter
  • Fixed some issues with tps reporter, resolves bug: tps reporter is wrong #165
  • Bump patch version
  • Resolves bug: wrong log at the start #166 by giving a different log, but not hiding it at the start; its not worth the effort to hide that at first-launch but instead we can show the batch size & num tasks it has as a diagnostic.

@erhant erhant self-assigned this Dec 27, 2024
@erhant erhant added the enhancement New feature or request label Jan 2, 2025
@erhant erhant marked this pull request as ready for review January 2, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erhant erhant

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: wrong log at the start bug: tps reporter is wrong
1 participant
@erhant