From 35e8402b4ea99ab56b5945efe38e316fc513d82a Mon Sep 17 00:00:00 2001 From: Swagat Bora Date: Mon, 17 Jul 2023 21:08:36 +0000 Subject: [PATCH] remove DCO check on commits in buildkite pipeline Signed-off-by: Swagat Bora --- .buildkite/logcheck.sh | 51 ----------------------------------------- .buildkite/pipeline.yml | 7 ------ 2 files changed, 58 deletions(-) delete mode 100755 .buildkite/logcheck.sh diff --git a/.buildkite/logcheck.sh b/.buildkite/logcheck.sh deleted file mode 100755 index 917566b3..00000000 --- a/.buildkite/logcheck.sh +++ /dev/null @@ -1,51 +0,0 @@ -#!/bin/sh -# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. -# -# Licensed under the Apache License, Version 2.0 (the "License"). You may -# not use this file except in compliance with the License. A copy of the -# License is located at -# -# http://aws.amazon.com/apache2.0/ -# -# or in the "license" file accompanying this file. This file is distributed -# on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either -# express or implied. See the License for the specific language governing -# permissions and limitations under the License. - -if [ -z "$BUILDKITE_PULL_REQUEST_BASE_BRANCH" ]; then - # only run on pull requests - exit 0 -fi - -found_fixups=0 -missing_dco=0 - -for sha in $(git log --no-merges --pretty=%H --no-decorate \ - "${BUILDKITE_PULL_REQUEST_BASE_BRANCH}"..HEAD); do - git show --pretty=oneline --no-decorate --no-patch $sha \ - | fgrep -q 'fixup!' && { - found_fixups=1 - echo "Found fixup commit $sha" - } - - git show --pretty=medium --no-decorate --no-patch $sha \ - | fgrep -q Signed-off-by: || { - missing_dco=1 - echo "Missing DCO on $sha" - } -done - -status=0 -if [ $found_fixups -gt 0 ]; then - status=1 -else - echo "Found no fixup commits" -fi - -if [ $missing_dco -gt 0 ]; then - status=1 -else - echo "All commits have Signed-off-by signature" -fi - -exit $status diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml index ce7cf609..13ea6892 100644 --- a/.buildkite/pipeline.yml +++ b/.buildkite/pipeline.yml @@ -42,13 +42,6 @@ steps: distro: "${BUILDKITE_AGENT_META_DATA_DISTRO}" hostname: "${BUILDKITE_AGENT_META_DATA_HOSTNAME}" - - label: 'git log validation' - command: './.buildkite/logcheck.sh' - # This should run in the same queue, but we don't care whether it runs on - # the same host. - agents: - queue: "${BUILDKITE_AGENT_META_DATA_QUEUE:-default}" - # This makes sure next step will run even if previous steps failed # to make sure we can reach the final step for resource cleanup - wait: ~