Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice to have: Method level filtering at the time of call logging #23

Open
chinuhub opened this issue Oct 9, 2017 · 1 comment
Open

Comments

@chinuhub
Copy link

chinuhub commented Oct 9, 2017

I am not sure if it is already supported but I couldn't find it myself. Here is the scenario. Many times we will have wrapper/getter methods which will simply get/set standard java collection objects likes maps etc. If we don't want to log these methods then there is no way to do it because we want other methods of this class to be instrumented and reported.

Can we make it possible to exclude some methods in a class from reporting?

@YoannBuch
Copy link
Contributor

That would definitely help to filter out some unnecessary noise, I agree.

Assuming that instrumenting these getters/setters is fine, we could imagine adding a way to filter getters/setters from the webapp. Currently we can only exclude packages and classes from the webapp.

We could either provide an out-of-the-box filter for getters/setters that use the naming convention that they start with "get" or "set". Or we could build something more generic that would take some sort of regexp like "com.foo.Bar:get*" to filter out all the methods of class Bar that starts with "get".

We could also support this filtering capability upstream, as an exclude filter that is set in the run configuration of IntelliJ. That would help create smaller recordings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants