Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not clear of the calling order of the nodes shown on the visualisation #17

Open
offworldcoder opened this issue Jun 27, 2017 · 1 comment

Comments

@offworldcoder
Copy link

offworldcoder commented Jun 27, 2017

I'm finding it very difficult to work out the calling order by looking at the visualization. This could be indicated by numbers similar to a communication diagram (http://www.uml-diagrams.org/communication-diagrams.html)

@offworldcoder offworldcoder changed the title Would be nice to see the calling order on the visualisation Not clear of the calling order of the nodes shown on the visualisation Jun 27, 2017
@YoannBuch
Copy link
Contributor

You're right, there is currently no ways to know when calls are being made between the different nodes (package/class/method) of the call graph.

If you want to follow the order of calls, you can use the call stack right below the call graph. Selecting the calls will highlight the corresponding package/class/method in the call graph.That being said I can understand that it may not be intuitive and too detailed.

Numbering calls like in communication diagrams is something to consider. I feel like it works well on small graphs but it would probably be really hard to follow on the kinds of call graphs we have in Flow. I'm not sure about your case, but I often end up with graphs with dozens of nodes and relationships. And one relationship that you see on the screen may actually represent hundreds of calls, and sometimes made at different times. I'm not sure that that numbering scheme would support the messy reality that Flow is uncovering. I have to think more about it, especially about how to handle iterations.

How many numbers would you have on the typical graph you generate with Flow?

Maybe we could implement something a little bit more interactive to follow the flow of execution on the call graph. For example we could have some sort of a handle on the timeline that when grabbed could slide along the time, and while doing so would highlight the node in the call graph that is being executed at the given time. What do you think? I'm open to other suggestions as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants