Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PatternMaker #2

Closed
Tracked by #12
dcallus opened this issue May 13, 2022 · 2 comments
Closed
Tracked by #12

Refactor PatternMaker #2

dcallus opened this issue May 13, 2022 · 2 comments
Assignees
@dcallus
Labels
enhancement New feature or request

Comments

@dcallus
Copy link
Contributor

dcallus commented May 13, 2022

Refactor the PatternMaker class so it uses create functions that are separate from the getters and setters, so it's clearer to follow the flow of logic and easier to build upon.

Also make it easier to transition to non 4/4 timings.
@dcallus dcallus added enhancement New feature or request good first issue Good for newcomers labels May 13, 2022
@dcallus dcallus self-assigned this May 13, 2022
@dcallus dcallus removed the good first issue Good for newcomers label May 13, 2022
@dcallus
Copy link
Contributor Author

dcallus commented May 13, 2022

removed accidental 'good first issue'.

@dcallus
Copy link
Contributor Author

dcallus commented May 26, 2022

Done

@dcallus dcallus closed this as completed May 26, 2022
@dcallus dcallus mentioned this issue Jun 11, 2022
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcallus dcallus

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dcallus