Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Remove go.rice completely from lotus #6715

Open
travisperson opened this issue Jul 8, 2021 · 2 comments · Fixed by #7125 · May be fixed by #12806
Open

[BUG] Remove go.rice completely from lotus #6715

travisperson opened this issue Jul 8, 2021 · 2 comments · Fixed by #7125 · May be fixed by #12806
Labels
dif/easy An existing lotus user should be able to pick this up good first issue Good for newcomers help wanted Extra attention is needed kind/bug Kind: Bug P1 P1: Must be resolved

Comments

@travisperson
Copy link
Contributor

travisperson commented Jul 8, 2021 •
edited
Loading

The use of go.rice was removed in #6208 to support AppImage, but it was not completely removed and still exists in a few places that needs to be fixed.

➜  lotus git:(master) ag "github.com/GeertJohan/go.rice"
cmd/lotus-townhall/main.go
11:	rice "github.com/GeertJohan/go.rice"

cmd/lotus-fountain/main.go
12:	rice "github.com/GeertJohan/go.rice"

go.mod
9:	github.com/GeertJohan/go.rice v1.0.0

go.sum
39:github.com/GeertJohan/go.rice v1.0.0 h1:KkI6O9uMaQU3VEKaj01ulavtF7o1fWT7+pk/4voiMLQ=
40:github.com/GeertJohan/go.rice v1.0.0/go.mod h1:eH6gbSOAUv07dQuZVnBmoDP8mgsM1rtixis4Tib9if0=

testplans/lotus-soup/go.sum
43:github.com/GeertJohan/go.rice v1.0.0 h1:KkI6O9uMaQU3VEKaj01ulavtF7o1fWT7+pk/4voiMLQ=
44:github.com/GeertJohan/go.rice v1.0.0/go.mod h1:eH6gbSOAUv07dQuZVnBmoDP8mgsM1rtixis4Tib9if0=

build/tools.go
6:	_ "github.com/GeertJohan/go.rice/rice"

This is a fresh clone of lotus, I do not believe go.rice should show up anywhere in the source tree.
@magik6k magik6k added dif/easy An existing lotus user should be able to pick this up good first issue Good for newcomers help wanted Extra attention is needed and removed need/triage labels Jul 28, 2021
@travisperson travisperson mentioned this issue Aug 18, 2021
Merged
@BigLep BigLep added the P1 P1: Must be resolved label Aug 18, 2021
@travisperson
Copy link
Contributor Author

#7125 does not fix this issue, as it doesn't remove go-rice from lotus.

@travisperson travisperson reopened this Aug 19, 2021
@ribasushi
Copy link
Collaborator

This is still an outstanding issue. The remaining functional use of rice is all contained in a single file: https://github.com/filecoin-project/lotus/blob/master/cmd/lotus-fountain/main.go

cc @rjan90 @masih

@rjan90 rjan90 linked a pull request Jan 3, 2025 that will close this issue
Draft
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dif/easy An existing lotus user should be able to pick this up good first issue Good for newcomers help wanted Extra attention is needed kind/bug Kind: Bug P1 P1: Must be resolved
Projects
None yet
Milestone
No milestone
4 participants
@BigLep @travisperson @ribasushi @magik6k